[lld] r187670 - Use report_fatal_error() instead of llvm_unreachable() to show broken input file error.

[Nick Kledzik]

On Aug 2, 2013, at 1:45 PM, Rui Ueyama <ruiu at google.com> wrote:

> Author: ruiu
> Date: Fri Aug  2 15:45:25 2013
> New Revision: 187670
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=187670&view=rev
> Log:
> Use report_fatal_error() instead of llvm_unreachable() to show broken input file error.
> 
> Modified:
>    lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
> 
> Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=187670&r1=187669&r2=187670&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)
> +++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Fri Aug  2 15:45:25 2013
> @@ -320,7 +320,7 @@ private:
>     for (COFFDefinedFileAtom *atom : atoms)
>       if (targetOffset < atom->originalOffset() + atom->size())
>         return atom;
> -    llvm_unreachable("Relocation target out of range");
> +    llvm::report_fatal_error("Relocation target out of range");
>   }

This really should return an error_code.  When lld is a library inside an app like an IDE, we don’t want to kill the whole app because of a malformed object file.

-Nick