[PATCH] Fixed the Intel-syntax X86 disassembler to respect the option for hexadecimal immediates.

Joey Gouly joey.gouly at arm.com
Thu Aug 1 12:56:18 PDT 2013



================
Comment at: lib/MC/MCInstPrinter.cpp:74
@@ +73,3 @@
+  switch(PrintHexStyle) {
+  default: // unreachable
+  case HexStyle::C:
----------------
Please actually add an llvm_unreachable here, if it really is unreachable.

================
Comment at: lib/MC/MCInstPrinter.cpp:97
@@ +96,3 @@
+  switch(PrintHexStyle) {
+  default: // unreachable
+  case HexStyle::C:
----------------
Same here.


http://llvm-reviews.chandlerc.com/D1243



More information about the llvm-commits mailing list