[PATCH] [Object] Split the ELF interface into 3 parts.

Sean Silva silvas at purdue.edu
Wed Jul 31 13:10:43 PDT 2013



================
Comment at: include/llvm/Object/ELF.h:113
@@ -553,1 +112,3 @@
 
+    uintX_t getEntSize() const { return EntitySize; }
+
----------------
Michael Spencer wrote:
> Rafael Ávila de Espíndola wrote:
> > nit: Which entities can be bigger than 4GB each? Maybe just using unsigned for EntitySize would do.
> > 
> Probably none, but I don't see why we should truncate unless there's a good reason. This class is going to be 16 bytes on a 64 bit system anyway.
```
typedef struct {
	Elf64_Word	sh_name;
	Elf64_Word	sh_type;
[...]
	Elf64_Xword	sh_entsize; // 64 bits
} Elf64_Shdr;
```

http://www.sco.com/developers/gabi/latest/ch4.sheader.html


http://llvm-reviews.chandlerc.com/D1033



More information about the llvm-commits mailing list