[llvm] r187385 - Elaborate a bit on the type unit and ODR conditional code.

[Eric Christopher]

Author: echristo
Date: Mon Jul 29 17:24:32 2013
New Revision: 187385

URL: http://llvm.org/viewvc/llvm-project?rev=187385&view=rev
Log:
Elaborate a bit on the type unit and ODR conditional code.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=187385&r1=187384&r2=187385&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Mon Jul 29 17:24:32 2013
@@ -1098,14 +1098,14 @@ void DwarfDebug::finalizeModuleInfo() {
     TheCU->constructContainingTypeDIEs();
   }
 
-  // For types that we'd like to move to type units or ODR check go ahead
-  // and either move the types out or add the ODR attribute now.
+  // Split out type units and conditionally add an ODR tag to the split
+  // out type.
   // FIXME: Do type splitting.
   for (unsigned i = 0, e = TypeUnits.size(); i != e; ++i) {
     MD5 Hash;
     DIE *Die = TypeUnits[i];
-    // If we're in C++ and we want to generate the hash then go ahead and do
-    // that now.
+    // If we've requested ODR hashes, the current language is C++, and the type
+    // isn't located inside a C++ anonymous namespace then add the attribute now.
     if (GenerateODRHash &&
         CUMap.begin()->second->getLanguage() == dwarf::DW_LANG_C_plus_plus &&
         !isContainedInAnonNamespace(Die))