[PowerPC, Mach-O] PPCMachObjectWriter.cpp, at long last

David Fang fang at csl.cornell.edu
Mon Jul 29 11:07:42 PDT 2013


Hi,
 	Any chance this patch could get some more review from PPC/Mach-O 
maintainers as well?  [patch attached to previous message in thread]
Thanks.

Fang

>> >  % darwin-to-linux-asm.sed hello-puts.s > hello-puts-linux.s
>> > 
>> >  % llvm-mc -triple=powerpc-apple-darwin8 -mcpu=g4 -relocation-model=pic
>> >  -filetype=obj hello-puts-linux.s -o hello-puts-linux.o
>> > 
>> >  I'm not partcularly comfortable going down this path with hacks.
>> >  I'd need to be advised on all the syntactic transformations needed.
>> >  Can't we just keep the llc -filetype=obj test for now until proper
>> >  darwin-asm syntax is supported?
>>
>>  Please don't. If you, the author, finds it hard to figure out what is
>>  difference, imagine someone doing refactoring and hitting problems
>>  with llc -filetype=obj. Tests like that are a maintenance nightmare.
>
> Patch updated.
> This now contains an llvm-mc test using syntactically transformed 
> darwin-to-linux asm.  I've confirmed that the object files produced by 
> llvm-mc and llc -filetype=obj are identical, but have left the llc -> .o test 
> commented out as you've requested.
>
> The two tests are in test/CodeGen/PowerPC, but can be relocated anywhere that 
> might seem more appropriate.

-- 
David Fang
http://www.csl.cornell.edu/~fang/




More information about the llvm-commits mailing list