[lld] r186884 - Fix -Wsign-compare warnings.

[Reid Kleckner]

Does 0x400000U not work with EXPECT_EQ?


On Mon, Jul 22, 2013 at 3:21 PM, Rui Ueyama <ruiu at google.com> wrote:

> Author: ruiu
> Date: Mon Jul 22 17:21:39 2013
> New Revision: 186884
>
> URL: http://llvm.org/viewvc/llvm-project?rev=186884&view=rev
> Log:
> Fix -Wsign-compare warnings.
>
> Modified:
>     lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp
>
> Modified: lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=186884&r1=186883&r2=186884&view=diff
>
> ==============================================================================
> --- lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp (original)
> +++ lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp Mon Jul 22
> 17:21:39 2013
> @@ -44,7 +44,7 @@ TEST_F(WinLinkParserTest, Basic) {
>    EXPECT_TRUE(_info.getInputSearchPaths().empty());
>    EXPECT_EQ(6, _info.getMinOSVersion().majorVersion);
>    EXPECT_EQ(0, _info.getMinOSVersion().minorVersion);
> -  EXPECT_EQ(0x400000, _info.getBaseAddress());
> +  EXPECT_EQ((uint64_t)0x400000, _info.getBaseAddress());
>    EXPECT_EQ(1024 * 1024ULL, _info.getStackReserve());
>    EXPECT_EQ(4096ULL, _info.getStackCommit());
>    EXPECT_FALSE(_info.allowRemainingUndefines());
> @@ -101,7 +101,7 @@ TEST_F(WinLinkParserTest, MinMajorMinorO
>
>  TEST_F(WinLinkParserTest, Base) {
>    EXPECT_FALSE(parse("link.exe", "-base", "8388608", "a.obj", nullptr));
> -  EXPECT_EQ(0x800000, _info.getBaseAddress());
> +  EXPECT_EQ((uint64_t)0x800000, _info.getBaseAddress());
>  }
>
>  TEST_F(WinLinkParserTest, StackReserve) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130729/a1333df1/attachment.html>