[patch] simplifyCFG for review
Ye, Mei
Mei.Ye at amd.com
Sun Jul 28 19:52:49 PDT 2013
It also depends on review turn-around time. I have to say that the review process is not clearly defined here. And it is the most lengthy review compared to other open sources.
-Mei
From: Chandler Carruth [mailto:chandlerc at google.com]
Sent: Sunday, July 28, 2013 5:26 PM
To: Ye, Mei
Cc: Andrew Trick; Matt Arsenault; Evan Cheng; llvm commits; Koenig, Christian
Subject: Re: [patch] simplifyCFG for review
On Sun, Jul 28, 2013 at 3:10 PM, Ye, Mei <Mei.Ye at amd.com<mailto:Mei.Ye at amd.com>> wrote:
I will re-factor the code following your suggestion. If the check-in process can’t be finished next week, please allow some delay since my sabbatical is coming.
FWIW, if you can't finish the refactoring in a reasonably short period of time, it might be more appropriate to pull this out and refactor it locally when you have time, and resubmit it.
Note, I don't have a problem with refactoring it in-tree, just don't want you to feel pressured to finish it in a short timeframe, and don't want others to be confused by the half-refactored state of things over a long period of time.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130729/bd483d2b/attachment.html>
More information about the llvm-commits
mailing list