[llvm] r187331 - Partial revert of 187310; it seems MSVC 10 still spits out this warning, but MSVC 11 does not.

[David Blaikie]

On Sun, Jul 28, 2013 at 11:04 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
> Author: aaronballman
> Date: Sun Jul 28 13:04:26 2013
> New Revision: 187331
>
> URL: http://llvm.org/viewvc/llvm-project?rev=187331&view=rev
> Log:
> Partial revert of 187310; it seems MSVC 10 still spits out this warning, but MSVC 11 does not.

Perhpas you could add a comment to explain this is an MSVC10 issue so
that when we drop compatibility for that we'll know it can be turned
back on, hopefully.

>
> Modified:
>     llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
>
> Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=187331&r1=187330&r2=187331&view=diff
> ==============================================================================
> --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
> +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Sun Jul 28 13:04:26 2013
> @@ -176,7 +176,8 @@ if( MSVC )
>      -wd4503 # Suppress ''identifier' : decorated name length exceeded, name was truncated'
>      -wd4624 # Suppress ''derived class' : destructor could not be generated because a base class destructor is inaccessible'
>      -wd4800 # Suppress ''type' : forcing value to bool 'true' or 'false' (performance warning)'
> -
> +    -wd4275 # Suppress 'An exported class was derived from a class that was not exported.'
> +
>      # Promoted warnings.
>      -w14062 # Promote 'enumerator in switch of enum is not handled' to level 1 warning.
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits