[Patch] Make errors and crashes distinct even with LLVM_DISABLE_CRASH_REPORT

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Jul 26 07:19:20 PDT 2013


On 25 July 2013 14:34, Reid Kleckner <rnk at google.com> wrote:
> AvoidMessageBoxHook does "*Return = 1" while CRTReportHook sets it to zero.
> Setting it to one is what gives us the stack trace, but it may also trigger
> the just in time debugger.  I'm really not sure what controls the system
> crash dialog, unfortunately.  Does someone else know more?

I am not sure, but it doesn't pop up in my VM and I do have msvc working.

This is the last thing blocking enabling pipefail. Would you be ok
with experimenting with it? That is, checking it in and watching the
bots?

Cheers,
Rafael



More information about the llvm-commits mailing list