[Patch] Make errors and crashes distinct even with LLVM_DISABLE_CRASH_REPORT

[Rafael Espíndola]

> I complicated things by adding yet another env var called
> LLVM_ENABLE_CRT_REPORT, which tries to suppress the "abort, retry, ignore"
> dialog raised by assertion failures when using the Visual CRT.  I think both
> of these vars are basically trying to achieve the same behavior of
> suppressing dialogs and slow system forensics gathering, so they could be
> merged.
>
> Currently, LLVM_DISABLE_CRASH_REPORTING turns off stack dumping on Windows
> but not on Mac.  This seems unintentional to me, and it means we don't get
> crash stack traces from 'check-clang' on Windows.  It'd be nice to get those
> without a dialog.

What about the attached patch?

It merges  LLVM_ENABLE_CRT_REPORT, gets a stack trace printed, "not
--crash" works and at least on my
system I don't get any dialog window.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 2012 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130725/9c80158b/attachment.obj>