[Patch] Make errors and crashes distinct even with LLVM_DISABLE_CRASH_REPORT

[Rafael Espíndola]

On 25 July 2013 11:54, Aaron Ballman <aaron at aaronballman.com> wrote:
> Wow, this code is pretty old (r82537 by ddunbar)!  I'm not certain
> removing it is the correct approach though -- the point to that is to
> disable crash reporting, and by removing it, the crash dialogs will
> appear again on system with post mortem debuggers installed.

ah, so that is why I was not getting a dialog. Does MSVC ship with a
post mortem debugger? Do I have to do something to enable it?

> On Windows, crashing really does exit much like exiting with a regular
> error, IIRC.  The resulting code (checked with %ERRORLEVEL%) is
> usually the exception code, but there's nothing magical about process
> return values except for 0.

I have attached a log showing the difference I get in one problematic
test (badpch.c). The lest invasive fix would probably be to change

 _exit(3);

to
 _exit(-3);

but we would still be trowing away a bit of information.

> I'm CCing in some folks who may have an opinion.
>
> ~Aaron

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: log
Type: application/octet-stream
Size: 3962 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130725/912c1310/attachment.obj>