[llvm] r185716 - Add a higher level createTemporaryFile function.
Hal Finkel
hfinkel at anl.gov
Thu Jul 25 07:58:53 PDT 2013
----- Original Message -----
> > When Suffix == "", this creates a file with a trailing '.', and
> > while there is nothing functionally wrong with this, it does look
> > a bit odd. Do you think that we could make this:
> >
> > Prefix + "-%%%%%%" + (Suffix.empty() ? StringRef("") :
> > StringRef(".")) + Suffix
> >
> > Or something similar instead?
>
> Sure, what do you think of the attached patch?
Thanks for doing this!
+ ASSERT_TRUE(TempPath2.endswith(".temp"));
This is an unrelated test case improvement?
Yea, looks fine to me!
-Hal
>
> Cheers,
> Rafael
>
--
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory
More information about the llvm-commits
mailing list