[llvm] r187093 - Replace the "NoFramePointerElimNonLeaf" target option with a function attribute.

Bill Wendling isanbard at gmail.com
Wed Jul 24 23:23:24 PDT 2013


On Jul 24, 2013, at 7:22 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Wed, Jul 24, 2013 at 5:34 PM, Bill Wendling <isanbard at gmail.com> wrote:
>> Author: void
>> Date: Wed Jul 24 19:34:29 2013
>> New Revision: 187093
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=187093&view=rev
>> Log:
>> Replace the "NoFramePointerElimNonLeaf" target option with a function attribute.
>> 
>> There's no need to specify a flag to omit frame pointer elimination on non-leaf
>> nodes...(Honestly, I can't parse that option out.) Use the function attribute
>> stuff instead.
> 
> I'm not sure what you mean by this bit. Presumably we need both these
> options on any given function because of inlining, for example (we
> might be OK with omitting frame pointers on leaf functions but a
> frontend won't know if a given function is a leaf at that point).
> 
It's badly worded. I just meant that we should use the function attribute instead of an llvm command line option.

-bw





More information about the llvm-commits mailing list