[PATCH] run the unit test for MemoryBuffer::getOpenFile in two different modes

[Rafael Espíndola]

What do you think of the attached patch? Splitting the interface so
that there is always only one size is probably better than asserting
that the correct size is passed.

On 23 July 2013 14:03, Eli Bendersky <eliben at google.com> wrote:
>
>
>
> On Tue, Jul 23, 2013 at 10:57 AM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>>
>> > Sure. But one question remains - is gold-plugin using the API of
>> > getOpenFile
>> > incorrectly by passing a positive Offset, and at the same time passing
>> > the
>> > buffer size into FileSize rather than MapSize?
>>
>> I am almost sure it is. I will try to change it too. Thanks for finding
>> this!
>>
>
> Cool. I'll wait until after your change(s) to push the updated test.
>
> Eli
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 10290 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130723/5df5b584/attachment.obj>