[lld] r186960 - Avoid using C-style cast and remove unnecessary LL prefix.
Rui Ueyama
ruiu at google.com
Tue Jul 23 10:25:25 PDT 2013
Author: ruiu
Date: Tue Jul 23 12:25:25 2013
New Revision: 186960
URL: http://llvm.org/viewvc/llvm-project?rev=186960&view=rev
Log:
Avoid using C-style cast and remove unnecessary LL prefix.
Modified:
lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp
Modified: lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=186960&r1=186959&r2=186960&view=diff
==============================================================================
--- lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp (original)
+++ lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp Tue Jul 23 12:25:25 2013
@@ -46,9 +46,9 @@ TEST_F(WinLinkParserTest, Basic) {
// Unspecified flags will have default values.
EXPECT_EQ(6, _info.getMinOSVersion().majorVersion);
EXPECT_EQ(0, _info.getMinOSVersion().minorVersion);
- EXPECT_EQ((uint64_t)0x400000, _info.getBaseAddress());
- EXPECT_EQ(1024 * 1024ULL, _info.getStackReserve());
- EXPECT_EQ(4096ULL, _info.getStackCommit());
+ EXPECT_EQ(0x400000U, _info.getBaseAddress());
+ EXPECT_EQ(1024 * 1024U, _info.getStackReserve());
+ EXPECT_EQ(4096U, _info.getStackCommit());
EXPECT_FALSE(_info.allowRemainingUndefines());
EXPECT_TRUE(_info.isNxCompat());
EXPECT_FALSE(_info.getLargeAddressAware());
@@ -84,7 +84,7 @@ TEST_F(WinLinkParserTest, Libpath) {
EXPECT_FALSE(parse("link.exe", "-libpath", "dir1", "-libpath", "dir2",
"a.obj", nullptr));
const std::vector<StringRef> &paths = _info.getInputSearchPaths();
- EXPECT_EQ((size_t)2, paths.size());
+ EXPECT_EQ(2U, paths.size());
EXPECT_EQ("dir1", paths[0]);
EXPECT_EQ("dir2", paths[1]);
}
@@ -105,31 +105,31 @@ TEST_F(WinLinkParserTest, MinMajorMinorO
TEST_F(WinLinkParserTest, Base) {
EXPECT_FALSE(parse("link.exe", "-base", "8388608", "a.obj", nullptr));
- EXPECT_EQ((uint64_t)0x800000, _info.getBaseAddress());
+ EXPECT_EQ(0x800000U, _info.getBaseAddress());
}
TEST_F(WinLinkParserTest, StackReserve) {
EXPECT_FALSE(parse("link.exe", "-stack", "8192", "a.obj", nullptr));
- EXPECT_EQ(8192ULL, _info.getStackReserve());
- EXPECT_EQ(4096ULL, _info.getStackCommit());
+ EXPECT_EQ(8192U, _info.getStackReserve());
+ EXPECT_EQ(4096U, _info.getStackCommit());
}
TEST_F(WinLinkParserTest, StackReserveAndCommit) {
EXPECT_FALSE(parse("link.exe", "-stack", "16384,8192", "a.obj", nullptr));
- EXPECT_EQ(16384ULL, _info.getStackReserve());
- EXPECT_EQ(8192ULL, _info.getStackCommit());
+ EXPECT_EQ(16384U, _info.getStackReserve());
+ EXPECT_EQ(8192U, _info.getStackCommit());
}
TEST_F(WinLinkParserTest, HeapReserve) {
EXPECT_FALSE(parse("link.exe", "-heap", "8192", "a.obj", nullptr));
- EXPECT_EQ(8192ULL, _info.getHeapReserve());
- EXPECT_EQ(4096ULL, _info.getHeapCommit());
+ EXPECT_EQ(8192U, _info.getHeapReserve());
+ EXPECT_EQ(4096U, _info.getHeapCommit());
}
TEST_F(WinLinkParserTest, HeapReserveAndCommit) {
EXPECT_FALSE(parse("link.exe", "-heap", "16384,8192", "a.obj", nullptr));
- EXPECT_EQ(16384ULL, _info.getHeapReserve());
- EXPECT_EQ(8192ULL, _info.getHeapCommit());
+ EXPECT_EQ(16384U, _info.getHeapReserve());
+ EXPECT_EQ(8192U, _info.getHeapCommit());
}
TEST_F(WinLinkParserTest, Force) {
More information about the llvm-commits
mailing list