[PATCH] Correct re-applying relocations on MIPS platforms

Petar Jovanovic Petar.Jovanovic at imgtec.com
Tue Jul 23 06:54:07 PDT 2013


________________________________________
From: Rafael EspĂ­ndola [rafael.espindola at gmail.com]
Sent: Tuesday, July 23, 2013 2:19 PM
To: Petar Jovanovic
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Correct re-applying relocations on MIPS platforms

On 22 July 2013 20:30, Petar Jovanovic <Petar.Jovanovic at imgtec.com> wrote:
> Hello everyone,
>
> here is a patch that corrects how multiple relocations are applied on MIPS.
>
> Similar to ARM change r182800, dynamic linker will reads bits/addends from
> the original object rather than from the object that might have been patched
> previously. For the purpose of relocations for MCJIT stubs on MIPS, we
> internally use otherwise unused MIPS relocations.
>
> The change also enables MCJIT unit tests for MIPS (EL/BE), and the following
> two tests now pass:
>
> - MCJITTest.return_global and
> - MCJITTest.multiple_functions.

> The previous ones were already passing? I.E.,  with this patch all the
> unit tests pass? If so, LGTM.
> Cheers,
> Rafael

Yes, the previous ones were already passing, but for these two we disabled
(r184461) all MCJIT unit tests.

Regards,
Petar




More information about the llvm-commits mailing list