TableGen generates an enum to name Schedule Model

[Vincent Lejeune]

Sorry for this.
Here is an updated version.

Thank




----- Mail original -----
> De : Jakob Stoklund Olesen <stoklund at 2pi.dk>
> À : Vincent Lejeune <vljn at ovi.com>
> Cc : Sean Silva <silvas at purdue.edu>; "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu>
> Envoyé le : Mardi 9 juillet 2013 18h20
> Objet : Re: TableGen generates an enum to name Schedule Model
> 
> 
> On Jul 9, 2013, at 7:05 AM, Vincent Lejeune <vljn at ovi.com> wrote:
> 
>>>  On Jul 8, 2013, at 6:02 PM, Sean Silva <silvas at purdue.edu> wrote:
>>> 
>>>>    Three tiny nits:
>>>> 
>>>>    +Instructions Itinerary can be queried using 
> MCDesc::getSchedClass() ; the 
>>>  value
>>>>    +can be named by an enum generated by Tablegen in the namespace 
> XXXSCHED ;
>>>>    +the name of the schedule classes are the same as provided in 
>>>  XXXSchedule.td plus
>>>>    +a default NoIntinerary class.
>>>> 
>>>>    These semicolons should be periods. Also, please capitalize the 
>>>  "g" in TableGen. Also, I think you mean "Instruction 
>>>  itineraries" and not "Instructions Itinerary”.
> 
>>  +Instructions itineraries can be queried using MCDesc::getSchedClass(). the
>>  +value can be named by an enum generated by TableGen in 
> XXXGenInstrInfo.inc.
>>  +the name of the schedule classes are the same as provided in 
> XXXSchedule.td plus
>>  +a default NoIntinerary class.
>>  +You will need to include XXXGenInstrInfo.inc after defining
>>  +GET_INSTRINFO_OPERAND_ENUM (see above). R600 provides an example of such
>>  +query :
> 
> Vincent, code reviews are not ed scripts. When Sean asked you to use periods 
> between your sentences, it is fairly safe to assume that he also meant for you 
> to capitalize the first word of sentences.
> 
> Your reference to GET_INSTRINFO_OPERAND_ENUM is also no longer relevant.
> 
> Please respect reviewers’ time. This is just sloppy.
> 
> Thanks,
> /jakob
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TableGen-Enumerate-Schedule-Model-too.patch
Type: text/x-patch
Size: 1742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130722/7baa5e9b/attachment.bin>