MC parser and PPC variants on constants

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Jul 19 14:31:35 PDT 2013


virtual const MCExpr *ApplyModifierToExpr(const MCExpr *E,
+                                            MCSymbolRefExpr::VariantKind) {

Start function name with a lowercase. Please define this virtual
function out of line.

With this patch I get a failure in ppc64-fixup-apply.s.


On 19 July 2013 17:05, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> On Sat, Jul 13, 2013 at 08:10:56PM +0200, Joerg Sonnenberger wrote:
>> PowerPC assembler supports expressions like "1234 at l". This doesn't with
>> MC right now, because the constant expression never reaches the target
>> layer. I wonder if it is really that useful to refactor this ATM,
>> especially since it likely makes sense to share the variant codes at
>> some point as many RISC platforms have similar needs in this area.
>
> New version with Target hook.
>
> Joerg
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list