[patch] Split openFileForWrite into windows and unix versions

Aaron Ballman aaron at aaronballman.com
Fri Jul 19 06:52:48 PDT 2013


Patch LGTM, thanks for taking care of this!

~Aaron

On Fri, Jul 19, 2013 at 9:30 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>> * I added the test for F_Binary, and it changes the output of (for
>> example) llc to use windows format. It would be really nice to add a
>> test for it. Any suggestion how to check for Carriage return in the
>> output?
>
> I just added a unittest.
>
> Cheers,
> Rafel




More information about the llvm-commits mailing list