[PATCH v2] X86: disambiguate unqualified btr, bts

[Hal Finkel]

----- Original Message -----
> > Hmm, I think I wasn't as clear as I could have been. For those
> > bit testing mnemonics with explicit size suffixes, a diagnostic
> > for immediates that are out of range seems correct. So [0,15] for
> > btw and friends, [0,31] for btl and friends, and [0,63] for btq and
> > friends.
> 
> I think I like that one even less. It means that we can't reassemble
> our own disassembly,

I've not been following this closely, but can you explain this? It sounds like we're producing instructions with out-of-range immediates in disassembly.

> and that the user has no way to specify the
> encodings with "out of range" immediates even if they wanted to (ours
> not to reason why etc).

This does not sound like a good reason. The assembler should reject immediates that are out of bound for the instruction. If the user wants to explicitly emit an invalid encoding, then they can use .long 0xwhatever.

 -Hal

> 
> Cheers.
> 
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory