Split openFileForRead into Windows and Unix versions

Reid Kleckner rnk at google.com
Wed Jul 17 04:52:49 PDT 2013


LGTM

We could pass FILE_SHARE_DELETE/WRITE to pretend to be more POSIX
filesystem-y, but that's really futile and all the other native tools block
file writes and deletes anyway.


On Wed, Jul 17, 2013 at 12:54 AM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> I am not completely convinced about this, but is has some advantages:
>
> * Lets us use native, utf16 windows functions.
> * Easy to produce good errors on windows about trying to use a
> directory when we want a file.
> * Simplifies the unix version a bit.
>
> What do you think?
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130717/8a2362bf/attachment.html>


More information about the llvm-commits mailing list