[PATCH] COFFDumper: Dump data directory entries.

[Chandler Carruth]

On Tue, Jul 16, 2013 at 2:37 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> > I agree with you in general but in this case consistency looks more
> > important than that. Look at the other methods, such as the above two.
> > getCOFFHeader() and getPE32Header() will never fail and will always
> return
> > object_error::success. Other methods in the other files in the same
> > directory are written in the similar manner. If we change the signature
> of
> > this function, it won't fix the API, but it'd make the API cluttered.
> >
> > I'd think we should change all the other methods in the directory not to
> > return error_code, if we think it's the right thing to do. That should be
> > done in another patch.
>
> I think we should change it all, yes. If you don't want to have the
> methods temporarily in a mixed state, then please change the existing
> ones first.


Rafael, I don't think that's necessary. This is all code that Rui has
written and been maintaining. If he would prefer to do the API rework in a
follow-up patch that seems totally fine.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/1a0b3d69/attachment.html>