[PATCH] [Support] Add a Unicode conversion wrapper from UTF16 to UTF8

Hans Wennborg hans at chromium.org
Tue Jul 16 10:01:25 PDT 2013


  Looks good to me.


================
Comment at: include/llvm/Support/ConvertUTF.h:240
@@ +239,3 @@
+ * ArrayRef<char> is used over StringRef because it cannot be constructed
+ * implicitly from a C string.
+ *
----------------
Maybe this comment is a bit redundant?

================
Comment at: unittests/Support/CMakeLists.txt:12
@@ -11,2 +11,3 @@
   Casting.cpp
+  ConvertUTFTest.cpp
   CommandLineTest.cpp
----------------
Sort order.


http://llvm-reviews.chandlerc.com/D1138

BRANCH
  convert-utf16-utf8-string

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list