[llvm] r185832 - Create files with the correct permission instead of changing it afterwards.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jul 16 07:58:16 PDT 2013


>>> Why 0664 and not 0666? Shouldn't the users umask determine determine the actual permissions? If I have 0000, I'd be surprised by a file produced with permissions 0664. E.g.,
>>
>> I agree, we should use 0666, but it is probably better to do that in
>> another patch, no?

I have fixed this in 186414. Thanks for noticing it!

Rebased patches attached.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lld.patch
Type: application/octet-stream
Size: 531 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/3af8fc12/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.patch
Type: application/octet-stream
Size: 23769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/3af8fc12/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: application/octet-stream
Size: 9025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/3af8fc12/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-extra.patch
Type: application/octet-stream
Size: 1036 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/3af8fc12/attachment-0003.obj>


More information about the llvm-commits mailing list