[llvm-commits] [llvm] r159203 - in /llvm/trunk: lib/Target/ARM/ARMAsmPrinter.cpp lib/Target/CellSPU/SPUAsmPrinter.cpp lib/Target/Hexagon/HexagonAsmPrinter.cpp lib/Target/MBlaze/MBlazeAsmPrinter.cpp lib/Target/NVPTX/NVPTXAsmPrinter.cpp lib/Target/Po...

[Richard Osborne]

On 15/07/13 21:00, Richard Osborne wrote:
> On 15 Jul 2013, at 20:03, Aaron Ballman <aaron at aaronballman.com> wrote:
>
>> On Mon, Jul 15, 2013 at 2:59 PM, Jack Carter <Jack.Carter at imgtec.com> wrote:
>>> Richard,
>>>
>>> If the original patch causes problems with XCore and MBlaze, that indicates to me that those targets are lacking sufficient tests in testsuite. I should not have been able to pass make check.
>> Normally I am fine adding test cases, but in this case, I don't know
>> XCore or MBlaze assembly well enough to actually craft a test case for
>> this (Richard's email was a bit Greek to me).  I could certainly
>> learn, but if you wanted to fix the code up and add test cases, that
>> would be greatly appreciated.
>>
>> ~Aaron
> Hi Aaron,
>
> That's fine - I'm happy fix up the code in the XCore backend and add some tests. Thanks again for pointing out the problem.
>
> Richard
>
I've fixed the XCore backend in r186407, and I've sent a separate patch 
for review to fix MBlaze 
(http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130715/181377.html).

-- 
Richard Osborne | XMOS
http://www.xmos.com