[PATCH] AEABI Divmod, take #2

[Kristof Beyls]

Hi Renato,

 

I've been looking only at the regression tests. I still have a few
questions:

 

1.       Quite a few test cases seem to be computing (a%b)+(a/b)+(b%a).
For these test cases I can see for "GNU" and "DARWIN" that the regression
tests look for 2 add instructions,
but for EABI, the tests only look for 1 add instruction.
I think that the checks should look for 2 add instructions, adding the right
registers.

2.       On test case longf, there's a FIXME saying "AEABI is not lowering
long u/srem into u/ldivmod", yet there is
a check for EABI that __aeabi_ldivmod is produced. Is the FIXME comment
still correct? If the FIXME
is no longer correct, there probably also should be checks for add
instructions in this test case?

3.       Test case g1: "DARWIB" -> "DARWIN"

 

Thanks,

 

Kristof

 

 

From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 16 July 2013 08:34
To: LLVM Commits; Kristof Beyls; Tim Northover; Anton Korobeynikov
Subject: Re: [PATCH] AEABI Divmod, take #2

 

Bump

 

On 14 July 2013 21:41, Renato Golin <renato.golin at linaro.org> wrote:

Hi folks,

 

Issues addressed:

 

* isTargetEABI -> isTargetAEABI

* Added 16-bit test

* Added register checks on all three variants

* There aren't redundant calls, they're related to the extra module
operation

 

cheers,

--renato

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/5e3b80cf/attachment.html>