[llvm] r178147 - Cleanup the simplify_type implementation.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jul 15 22:11:16 PDT 2013


> The extra enable_ifs were intentionally added in r175819 to avoid the
> accidental usage of unsafe casts.  Is there some justification for why
> they are no longer necessary?
>
> (Sorry about digging up old commits... I just happened to notice this now.)

NP. Sorry I missed that. I think the attached patch fixes it, but do
you have any suggestions on how to prevent this being lost again? Do
we have some form of negative compilation test or should I try to use
sfinae in a test to check that we cannot cast an rvalue?

> -Eli

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 2615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130716/7aeaf51b/attachment.obj>


More information about the llvm-commits mailing list