[llvm] r186380 - Remember that we have a null terminated string.

[Rafael Espindola]

Author: rafael
Date: Mon Jul 15 22:30:10 2013
New Revision: 186380

URL: http://llvm.org/viewvc/llvm-project?rev=186380&view=rev
Log:
Remember that we have a null terminated string.

This is a micro optimization. Instead of going char*->StringRef->Twine->char*,
go char*->Twine->char* and avoid having to copy the filename on the stack.

Modified:
    llvm/trunk/tools/llvm-ar/llvm-ar.cpp

Modified: llvm/trunk/tools/llvm-ar/llvm-ar.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/llvm-ar.cpp?rev=186380&r1=186379&r2=186380&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-ar/llvm-ar.cpp (original)
+++ llvm/trunk/tools/llvm-ar/llvm-ar.cpp Mon Jul 15 22:30:10 2013
@@ -387,7 +387,7 @@ public:
   NewArchiveIterator(std::vector<std::string>::const_iterator I, Twine Name);
   bool isNewMember() const;
   object::Archive::child_iterator getOld() const;
-  StringRef getNew() const;
+  const char *getNew() const;
   StringRef getMemberName() const { return MemberName; }
 };
 }
@@ -411,9 +411,9 @@ object::Archive::child_iterator NewArchi
   return OldI;
 }
 
-StringRef NewArchiveIterator::getNew() const {
+const char *NewArchiveIterator::getNew() const {
   assert(IsNewMember);
-  return *NewI;
+  return NewI->c_str();
 }
 
 template <typename T>
@@ -556,7 +556,7 @@ static void performWriteOperation(Archiv
 
     if (I->isNewMember()) {
       // FIXME: we do a stat + open. We should do a open + fstat.
-      StringRef FileName = I->getNew();
+      const char *FileName = I->getNew();
       sys::fs::file_status Status;
       failIfError(sys::fs::status(FileName, Status), FileName);