[PATCH] [mc-coff] Resolve aliases when emitting COFF relocations
Reid Kleckner
rnk at google.com
Mon Jul 15 05:19:23 PDT 2013
================
Comment at: test/MC/COFF/alias.s:20
@@ +19,3 @@
+ .long _bar3
+ .long _bar4
+
----------------
Saleem Abdulrasool wrote:
> It would be nice if you would rename these to be a bit more helpful.
>
> e.g.:
>
> .globl _external_aliased_to_local
> _local:
> _external_aliased_to_local = _local
Sure. These came from the ELF alias test, and truthfully I don't fully understand their meaning.
================
Comment at: test/MC/COFF/alias.s:22
@@ +21,3 @@
+
+// FIXME: To reviewer, please provide guidance on how to improve this test.
+
----------------
Saleem Abdulrasool wrote:
> Id say drop this before committing.
Mostly I want someone with MC test experience to tell me if the output below is a good MC test.
http://llvm-reviews.chandlerc.com/D1079
More information about the llvm-commits
mailing list