[PATCH] [mc-coff] Resolve aliases when emitting COFF relocations
Saleem Abdulrasool
compnerd at compnerd.org
Sat Jul 13 11:24:49 PDT 2013
================
Comment at: test/MC/COFF/alias.s:22
@@ +21,3 @@
+
+// FIXME: To reviewer, please provide guidance on how to improve this test.
+
----------------
Id say drop this before committing.
================
Comment at: test/MC/COFF/alias.s:20
@@ +19,3 @@
+ .long _bar3
+ .long _bar4
+
----------------
It would be nice if you would rename these to be a bit more helpful.
e.g.:
.globl _external_aliased_to_local
_local:
_external_aliased_to_local = _local
http://llvm-reviews.chandlerc.com/D1079
More information about the llvm-commits
mailing list