[compiler-rt] r186109 - Fix a veritable conucopia of bugs in the readdir_r interceptors.

Chandler Carruth chandlerc at gmail.com
Fri Jul 12 05:21:10 PDT 2013


First of all...

On Fri, Jul 12, 2013 at 5:12 AM, Alexey Samsonov <samsonov at google.com>wrote:

> Why? Manual for mbstowcs and friends explicitly tells that trailing '\0'
> is *not* always appended
> (I've verified this by running these functions manually), so we actually
> have to consider different cases here,
> as the original code does. I went on and reverted these changes in r186155.
>
> Your change also broke our buildbots and MemorySanitizer tests ("make
> check-msan"). It is possible that
> you haven't noticed this because MSan unit tests are not built in your
> build tree - most likely you don't
> have "projects/libcxx" checked out - it is required to build MSan
> unittests.
>

None of the mbstowcs changes were intentional... I don't know how they even
happened. I blame either rogue commands to my editor or syncing to a weir
revision... Very sorry about that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130712/f3ddee71/attachment.html>


More information about the llvm-commits mailing list