[PATCH] fix for PR16393: miscompile with struct byval

Jakob Stoklund Olesen jolesen at apple.com
Thu Jul 11 18:43:47 PDT 2013


On Jul 11, 2013, at 5:53 PM, Manman Ren <mren at apple.com> wrote:

> Attached patch after refactoring (at r186141).

Neat, thanks.

> The patch removes a rudimentary check in PEI: it is invalid when we have a
> FrameDestroy <n> followed by a FrameSetup <m> in a single basic block.

I would like to see some comments explaining what is going on, but otherwise I am really happy with this approach.

Jim, what do you think about this kind of PEI change?

/jakob




More information about the llvm-commits mailing list