[llvm] r186035 - Add a comment.

[Adrian Prantl]

On Jul 10, 2013, at 2:55 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Wed, Jul 10, 2013 at 2:47 PM, Adrian Prantl <aprantl at apple.com> wrote:
>> 
>> On Jul 10, 2013, at 2:14 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> 
>>> On Wed, Jul 10, 2013 at 2:08 PM, Adrian Prantl <aprantl at apple.com> wrote:
>>>> Author: adrian
>>>> Date: Wed Jul 10 16:08:02 2013
>>>> New Revision: 186035
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=186035&view=rev
>>>> Log:
>>>> Add a comment.
>>> 
>>> Is this the minimal source required to reproduce the issue? Is it
>>> really dependent on templates?
>> 
>> It’s a backend testcase, so obviously the answer is no,
> 
> What I mean is: could we still test this bug with an example that
> doesn't have templates in it. (ie: is the source code minimized)
> 
>> but I’m not convinced that manually instantiating templates in a comment in a test case is the best use of anyone’s time :-)
> 
> Not sure I follow, but maybe: I do think it's a valuable use of
> someone's time to provide simple test cases. The way I'd prefer to see
> debug info test cases simplified is by simplifying the input source,
> not hand-simplifying the IR. This will keep them small, but
> maintainable.

Done in r186119. Did you get a chance to look at my other mail from yesterday?

thanks,
adrian