[compiler-rt] Fixing Linux compile error due to use of clone

Reid Kleckner rnk at google.com
Wed Jul 10 15:49:04 PDT 2013


This change is probably fine.  I think those args are only accessed if
certain flags are set.

That said, I'd honestly be surprised if the sanitizers work at all on Linux
2.4 with just this change.  I doubt anyone is testing it.


On Wed, Jul 10, 2013 at 6:33 PM, Andy Jost <Andrew.Jost at synopsys.com> wrote:

>  First post to llvm-commits, so I may not know the process.  I’m hoping
> someone will review and submit this for me.****
>
> ** **
>
> The attached patch fixes an unsafe use of clone in
> projects/compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_linux_libcdep.cc.
> ****
>
> ** **
>
> From the clone man page:****
>
> ****
>
> In Linux 2.4 and earlier, clone() does not take arguments ptid, tls, and
> ctid. ****
>
> ** **
>
> Those last three arguments are unused in this case, anyway, so I just
> removed them.  This fixes the build of compiler-rt on my machine. ****
>
> ** **
>
> Is a testcase needed?  If so, where should I look to get started?****
>
> ** **
>
> -Andy****
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130710/87afd69c/attachment.html>


More information about the llvm-commits mailing list