[llvm] r186035 - Add a comment.

[Adrian Prantl]

On Jul 10, 2013, at 2:14 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Wed, Jul 10, 2013 at 2:08 PM, Adrian Prantl <aprantl at apple.com> wrote:
>> Author: adrian
>> Date: Wed Jul 10 16:08:02 2013
>> New Revision: 186035
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=186035&view=rev
>> Log:
>> Add a comment.
> 
> Is this the minimal source required to reproduce the issue? Is it
> really dependent on templates?

It’s a backend testcase, so obviously the answer is no, but I’m not convinced that manually instantiating templates in a comment in a test case is the best use of anyone’s time :-)
> 
> I'd like to have the source reduced & the IR left untouched if
> possible - rather than manually reducing the IR from more complex
> source. This'll make it easier to regenerate the test case if it needs
> to be tweaked/enhanced in the future.

My take on this is that if someone _really_ wants to tweak this test in the future they will probably be happier with the actual source code that the test was generated from.

Let me know what you think -- if you feel strongly about it I can build a reduced-C++/full LLVM version if the thing.

cheers,
adrian