[lld] r185657 - Don't pass llvm::errs() all over the place. Diagnostics always go to stderr.

[Nick Kledzik]

Michael,

At the bottom of lld/CMakeLists.txt you put:

if (LLVM_INCLUDE_TESTS AND NOT LLD_BUILT_STANDALONE)
  add_subdirectory(unittests)
endif()

Why is the use of unittests conditionalized like that?   It seems to be causing the buildbots to not run the unittests.   It also means Rafael did not see that his changes broke a bunch of the unit tests.

Does the variable LLD_BUILT_STANDALONE refer to if the lld sources are place inside of llvm sources or not?   Why should that change if unit tests are run?

-Nick

On Jul 5, 2013, at 1:38 PM, Nick Kledzik <kledzik at apple.com> wrote:
> I just recently noticed that those unittests are not being built and run as part of the lld-test target.  I’m still trying to figure out why.