[llvm] r185886 - This patch changes the saved IRBuilder insert point from BasicBlock::iterator to AssertingVH.

[Rafael Espíndola]

Hi Nadav,

This broke the valgrind bots:

http://lab.llvm.org:8011/builders/llvm-x86_64-linux-vg_leak/builds/917/steps/test-llvm/logs/LLVM%3A%3Acrash_7zip.ll

On 8 July 2013 19:31, Nadav Rotem <nrotem at apple.com> wrote:
> Author: nadav
> Date: Mon Jul  8 18:31:13 2013
> New Revision: 185886
>
> URL: http://llvm.org/viewvc/llvm-project?rev=185886&view=rev
> Log:
>
> This patch changes the saved IRBuilder insert point from BasicBlock::iterator to AssertingVH.
>
> Commit 185883 fixes a bug in the IRBuilder that should fix the ASan bot. AssertingVH can help in exposing some RAUW problems.
>
> Thanks Ben and Alexey!
>
>
> Modified:
>     llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
>
> Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=185886&r1=185885&r2=185886&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)
> +++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Mon Jul  8 18:31:13 2013
> @@ -66,7 +66,7 @@ private:
>    BuilderLocGuard(const BuilderLocGuard &);
>    BuilderLocGuard &operator=(const BuilderLocGuard &);
>    IRBuilder<> &Builder;
> -  BasicBlock::iterator Loc;
> +  AssertingVH<Instruction> Loc;
>  };
>
>  /// A helper class for numbering instructions in multible blocks.
> @@ -1217,6 +1217,7 @@ Value *BoUpSLP::vectorizeTree(TreeEntry
>  }
>
>  void BoUpSLP::vectorizeTree() {
> +  Builder.SetInsertPoint(&F->getEntryBlock());
>    vectorizeTree(&VectorizableTree[0]);
>
>    // For each vectorized value:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits