[llvm] r185876 - DebugInfo: remove unused helper function getDICompositeType.

[Manman Ren]

For type uniquing, we are going to replace references to DIType with a String.

If we can't remove getDICompositeType, we need to update its interface to take a DITypeHashMap reference,
since getTypeDerivedFrom needs the map to look up the actual DIType from a String.

Thanks,
Manman

-/// getDICompositeType - Find underlying composite type.
-DICompositeType llvm::getDICompositeType(DIType T) {
-  if (T.isCompositeType())
-    return DICompositeType(T);
-
-  if (T.isDerivedType())
-    return getDICompositeType(DIDerivedType(T).getTypeDerivedFrom());
-
-  return DICompositeType();
-}

On Jul 8, 2013, at 5:18 PM, Eric Christopher wrote:

> This appears to have broken all of the dragonegg bots. I've reverted it here:
> 
> M include/llvm/DebugInfo.h
> M lib/IR/DebugInfo.cpp
> Committed r185890
> 
> I haven't audited the dragonegg code to see what the use is here.
> 
> -eric
> 
> 
> On Mon, Jul 8, 2013 at 2:55 PM, Manman Ren <mren at apple.com> wrote:
>> Author: mren
>> Date: Mon Jul  8 16:55:46 2013
>> New Revision: 185876
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=185876&view=rev
>> Log:
>> DebugInfo: remove unused helper function.
>> 
>> Modified:
>>    llvm/trunk/include/llvm/DebugInfo.h
>>    llvm/trunk/lib/IR/DebugInfo.cpp
>> 
>> Modified: llvm/trunk/include/llvm/DebugInfo.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo.h?rev=185876&r1=185875&r2=185876&view=diff
>> ==============================================================================
>> --- llvm/trunk/include/llvm/DebugInfo.h (original)
>> +++ llvm/trunk/include/llvm/DebugInfo.h Mon Jul  8 16:55:46 2013
>> @@ -695,9 +695,6 @@ namespace llvm {
>>   /// getDISubprogram - Find subprogram that is enclosing this scope.
>>   DISubprogram getDISubprogram(const MDNode *Scope);
>> 
>> -  /// getDICompositeType - Find underlying composite type.
>> -  DICompositeType getDICompositeType(DIType T);
>> -
>>   /// isSubprogramContext - Return true if Context is either a subprogram
>>   /// or another context nested inside a subprogram.
>>   bool isSubprogramContext(const MDNode *Context);
>> 
>> Modified: llvm/trunk/lib/IR/DebugInfo.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DebugInfo.cpp?rev=185876&r1=185875&r2=185876&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/IR/DebugInfo.cpp (original)
>> +++ llvm/trunk/lib/IR/DebugInfo.cpp Mon Jul  8 16:55:46 2013
>> @@ -844,17 +844,6 @@ DISubprogram llvm::getDISubprogram(const
>>   return DISubprogram();
>> }
>> 
>> -/// getDICompositeType - Find underlying composite type.
>> -DICompositeType llvm::getDICompositeType(DIType T) {
>> -  if (T.isCompositeType())
>> -    return DICompositeType(T);
>> -
>> -  if (T.isDerivedType())
>> -    return getDICompositeType(DIDerivedType(T).getTypeDerivedFrom());
>> -
>> -  return DICompositeType();
>> -}
>> -
>> /// isSubprogramContext - Return true if Context is either a subprogram
>> /// or another context nested inside a subprogram.
>> bool llvm::isSubprogramContext(const MDNode *Context) {
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits