[RFC, PowerPC] Always use "assembler dialect" 1

Hal Finkel hfinkel at anl.gov
Mon Jul 8 13:12:44 PDT 2013


----- Original Message -----
> Hal Finkel <hfinkel at anl.gov> wrote on 08.07.2013 20:59:31:
> 
> > Of the two, I'd be in favor of adding an isDarwin field, and that
> > will make it clear what is going on. However, is there a reason
> > that
> > we just can't give the printer access to the target triple somehow
> > (either directly, or via a MCSubtargetInfo object, etc.)?
> 
> Ah, right, we do have a MCSubtargetInfo.  This would take care of
> the InstPrinter.   For the PPCMCExpr, we can just add an explicit
> isDarwin parameter and pass it in at creation (after reverting
> the 184441 revision).   It ends up a bit more wordy, but overall
> probably clearer ...
> 
> (See attached file: diff-llvm-asmdialect2)

Great! LGTM.

 -Hal

> 
> Bye,
> Ulrich
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list