[llvm] r185853 - Add a comment to this change, requested by Eric Christopher.

Joey Gouly joey.gouly at arm.com
Mon Jul 8 12:52:52 PDT 2013


Author: joey
Date: Mon Jul  8 14:52:51 2013
New Revision: 185853

URL: http://llvm.org/viewvc/llvm-project?rev=185853&view=rev
Log:
Add a comment to this change, requested by Eric Christopher.

Modified:
    llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp
    llvm/trunk/test/CodeGen/ARM/arm-modifier.ll

Modified: llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp?rev=185853&r1=185852&r2=185853&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp Mon Jul  8 14:52:51 2013
@@ -3491,6 +3491,10 @@ SDNode *ARMDAGToDAGISel::SelectInlineAsm
     else
       continue;
 
+    // Immediate operands to inline asm in the SelectionDAG are modeled with
+    // two operands. The first is a constant of value InlineAsm::Kind_Imm, and
+    // the second is a constant with the value of the immediate. If we get here
+    // and we have a Kind_Imm, skip the next operand, and continue.
     if (Kind == InlineAsm::Kind_Imm) {
       SDValue op = N->getOperand(++i);
       AsmNodeOperands.push_back(op);

Modified: llvm/trunk/test/CodeGen/ARM/arm-modifier.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/arm-modifier.ll?rev=185853&r1=185852&r2=185853&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/arm-modifier.ll (original)
+++ llvm/trunk/test/CodeGen/ARM/arm-modifier.ll Mon Jul  8 14:52:51 2013
@@ -66,6 +66,7 @@ entry:
   ret i64 %0
 }
 
+; PR16490
 define void @f5(i64 %__pu_val) {
   call void asm sideeffect "$1", "r,i"(i64 %__pu_val, i32 -14)
   ret void





More information about the llvm-commits mailing list