[llvm] r185688 - PR16490: fix a crash in ARMDAGToDAGISel::SelectInlineAsm.
Eric Christopher
echristo at gmail.com
Mon Jul 8 10:35:15 PDT 2013
This might make a great comment...
> In the SelectionDAG immediate operands to inline asm are constructed as
> two separate operands. The first is a constant of value InlineAsm::Kind_Imm
> and the second is a constant with the value of the immediate.
... here :)
> + if (Kind == InlineAsm::Kind_Imm) {
> + SDValue op = N->getOperand(++i);
> + AsmNodeOperands.push_back(op);
> + continue;
> + }
>
Adding the PR number here would help as well.
> +
> +define void @f5(i64 %__pu_val) {
> + call void asm sideeffect "$1", "r,i"(i64 %__pu_val, i32 -14)
> + ret void
> +}
>
Also close the PR? :)
-eric
More information about the llvm-commits
mailing list