[PATCH][X86_64/MC] Towards usable Win64 exception handling

[Chandler Carruth]

Kai, I hate to say this but these patches should not be committed based on
Charles and Nico's review alone. While their review helps, you will need
one of the long-time committers to the codegen area to give final approval
on the design and structure of these patches.

Please back this patch series out and ping the list asking for one of the
existing maintainers to look at the patches. Notably, the last long-time
maintainer to look at this patch series (Anton) had questions and didn't
express that this LGTM.

I'm sorry the process is extended and it is hard to get good reviews, but
letting patches in without thorough review doesn't solve the problem, it
just lowers the quality standards for the project.

(For the record, I'm not saying there *is* a problem with these patches,
I'm saying that we need to follow a reasonable practice here and get good
review on the design before committing.)


On Sat, Jul 6, 2013 at 10:25 AM, Kai Nacke <kai.nacke at redstar.de> wrote:

> Thanks for the review.
>
> Commited in r185758..r185761
>
> Kai
>
>
> On 03.07.2013 22:45, Charles Davis wrote:
>
>>
>> On Jul 3, 2013, at 10:28 AM, Kai Nacke wrote:
>>
>>  Hi!
>>>
>>> Please, I still need a review for the set of attached patches. They are
>>> really needed for working Win64 SEH support. Implementation of Dwarf EH
>>> handling on top of Win64 SEH is then a follow-up patch.
>>>
>>> The first patch fixes the now failing seh.s test. The second patch
>>> changes the relocation type to IMAGE_REL_AMD64_ADDR32NB as required by the
>>> MS COFF spec. The third patch addresses an alignment problem inside the
>>> unwind info data structure (this one is new). The fourth patch outputs the
>>> personality function and the language data into the right places.
>>>
>> All four LGTM.
>>
>> Chip
>>
>>
>> ______________________________**_________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>>
>>
> ______________________________**_________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130707/f10cd190/attachment.html>