[llvm] r185627 - Supporting ssize_t on WIN64 with its proper size. Patch thanks to David Cournapeau!

[David Majnemer]

Aren't these guarded by _MSC_VER? long is always 32-bit on that compiler. Given that Microsoft defines ssize_t as long on 32-bit windows, I see no reason why we shouldn't either.

Sent from my iPhone

On Jul 4, 2013, at 10:09 AM, Aaron Ballman <aaron at aaronballman.com> wrote:

> On Thu, Jul 4, 2013 at 12:58 PM, David Cournapeau <davidc at enthought.com> wrote:
>> 
>> 
>> 
>> On Thu, Jul 4, 2013 at 5:03 PM, David Majnemer <david.majnemer at gmail.com>
>> wrote:
>>> 
>>> Unless I am mistaken, this commit has the DataTypes.h.cmake file using int
>>> for 32 bit Windows while the DataTypes.h.in file used long. For consistency,
>>> we should use long to match what msdn specifies.
>> 
>> 
>> agreed, maybe the int was introduced by mistake, long is the one we should
>> use for consistency.
> 
> int was what was previously used, so that's the consistency I was
> going for.  If we wanted to get pedantic, we should use __int32 and
> __int64 since this is MSVC-specific.
> 
> ~Aaron