[PATCH] Introduce a GlobalList ctor which takes a MemoryBuffer to make it more unit testable.
Alexey Samsonov
samsonov at google.com
Thu Jul 4 05:07:53 PDT 2013
I support this change (w/ original "BlackList" naming).
================
Comment at: lib/Transforms/Utils/GlobalList.cpp:42
@@ -41,1 +41,3 @@
+ init(File.take());
+}
----------------
Please merge D1093 here.
================
Comment at: include/llvm/Transforms/Utils/GlobalList.h:46
@@ -44,1 +45,3 @@
GlobalList(const StringRef Path);
+ GlobalList(MemoryBuffer *MB);
+
----------------
This should be const MemoryBuffer*
http://llvm-reviews.chandlerc.com/D1090
BRANCH
globallist2
ARCANIST PROJECT
llvm
More information about the llvm-commits
mailing list