[PATCH] PR16490: Fix a crash in ARM inline asm

Joey Gouly joey.gouly at arm.com
Wed Jul 3 08:29:34 PDT 2013


I'm waiting for Vinicius to do a build, just to double check it actually
fixes it for him. If so, I will commit it later, thanks!

Joey

From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Renato Golin
Sent: 03 July 2013 15:20
To: Tim Northover
Cc: reviews+D1084+public+e2c460ea27e2b685 at llvm-reviews.chandlerc.com;
llvm-commits
Subject: Re: [PATCH] PR16490: Fix a crash in ARM inline asm

On 3 July 2013 13:34, Tim Northover <t.p.northover at gmail.com> wrote:
It looks good to me. Quite a convoluted path these things were taking
before.

Indeed, I was wondering about the DAG dependency missing on the previous
patch, but I'm not an expert on that area.

Looks good to me, too. Vinicius will generate some more cases for the test,
we can commit on a separate patch later on.

Thanks!
--renato







More information about the llvm-commits mailing list