[llvm] r185389 - PR16493: DebugInfo with TLS on PPC crashing due to invalid relocation

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Tue Jul 2 12:06:10 PDT 2013


David Blaikie <dblaikie at gmail.com> wrote on 02.07.2013 18:31:41:

> > The attached patch hold all these changes.  Does this
> > look reasonable?
>
> Yep. Please commit - if you'd like, you could break this out into a
> no-functionality-changing patch to add DIEExpr (& undo my changes to
> DIELabel, as you have) then the change to generalize the
> API/containers to MCExpr & add PPC TLS support. Not necessary if you
> want to just do it in one go that's not a problem either.

Checked in as revisions 185458 .. 185461.

> (& please mention the PR in your commit)

Oops, forgot about that, sorry.  But I've now added a comment
to the PR itself pointing to the revision containing the fix.

Thanks again for the review!

Bye,
Ulrich




More information about the llvm-commits mailing list