[llvm] r185378 - Make PBQP require/preserve MachineLoopInfo - the spiller requires it.

[David Blaikie]

On Jul 1, 2013 9:05 PM, "Lang Hames" <lhames at gmail.com> wrote:
>
> That would imply that PBQP was less than eternally perfect.
>
> Actually we tend to test register allocators with the test suite, rather
than regression tests.

Ah, right, the whole lack of backend modularity. Hopefully Dan or someone
will figure out that machine IR serialization and we can then start getting
some teat coverage.

>  Of course we don't have a PBQP nightly tester either... I'll work on
that.

Right

>
>
> On Mon, Jul 1, 2013 at 2:09 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> On Mon, Jul 1, 2013 at 1:47 PM, Lang Hames <lhames at gmail.com> wrote:
>> > Author: lhames
>> > Date: Mon Jul  1 15:47:47 2013
>> > New Revision: 185378
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=185378&view=rev
>> > Log:
>> > Make PBQP require/preserve MachineLoopInfo - the spiller requires it.
>>
>> Test case?
>>
>> >
>> > Modified:
>> >     llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp
>> >
>> > Modified: llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp
>> > URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp?rev=185378&r1=185377&r2=185378&view=diff
>> >
==============================================================================
>> > --- llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp (original)
>> > +++ llvm/trunk/lib/CodeGen/RegAllocPBQP.cpp Mon Jul  1 15:47:47 2013
>> > @@ -43,6 +43,7 @@
>> >  #include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
>> >  #include "llvm/CodeGen/MachineDominators.h"
>> >  #include "llvm/CodeGen/MachineFunctionPass.h"
>> > +#include "llvm/CodeGen/MachineLoopInfo.h"
>> >  #include "llvm/CodeGen/MachineRegisterInfo.h"
>> >  #include "llvm/CodeGen/PBQP/Graph.h"
>> >  #include "llvm/CodeGen/PBQP/HeuristicSolver.h"
>> > @@ -436,6 +437,8 @@ void RegAllocPBQP::getAnalysisUsage(Anal
>> >    au.addPreserved<LiveStacks>();
>> >    au.addRequired<MachineBlockFrequencyInfo>();
>> >    au.addPreserved<MachineBlockFrequencyInfo>();
>> > +  au.addRequired<MachineLoopInfo>();
>> > +  au.addPreserved<MachineLoopInfo>();
>> >    au.addRequired<MachineDominatorTree>();
>> >    au.addPreserved<MachineDominatorTree>();
>> >    au.addRequired<VirtRegMap>();
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130701/f124e001/attachment.html>