[PATCH] Fix CodeGen/PowerPC/stack-protector.ll test case on OpenBSD

Hal Finkel hfinkel at anl.gov
Fri Jun 28 13:20:06 PDT 2013


----- Original Message -----
> On Mon, Jun 24, 2013 at 3:24 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> >> On OpenBSD, the stack smash protection transform uses
> >> "__guard_local"
> >> and "__stack_smash_handler" instead of "__stack_chk_guard" and
> >> "__stack_chk_fail".  However, CodeGen/PowerPC/stack-protector.ll
> >> doesn't specify a target OS, so on OpenBSD it fails.
> >>
> >> Easy fix: Add -mtriple=ppc32-unknown-linux to make the test more
> >> host
> >> OS agnostic.
> >>
> >> While here, it's easy enough to switch to FileCheck so llc only
> >> needs
> >> to run once.  I think this is a win?
> >
> > I don't think that you need the '-o -' part because you're feeding
> > llc from stdin.
> 
> Ah, I just left that part the same as it was.  Looks like you're
> right though.
> 
> > Otherwise, LGTM. Thanks!
> 
> Would you mind committing this for me then?  I don't have LLVM commit
> access.

r185206, thanks!

 -Hal

> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list