[llvm] r185141 - Improve comment.

Rafael Espindola rafael.espindola at gmail.com
Fri Jun 28 03:55:41 PDT 2013


Author: rafael
Date: Fri Jun 28 05:55:41 2013
New Revision: 185141

URL: http://llvm.org/viewvc/llvm-project?rev=185141&view=rev
Log:
Improve comment.

Modified:
    llvm/trunk/lib/Support/Path.cpp

Modified: llvm/trunk/lib/Support/Path.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Path.cpp?rev=185141&r1=185140&r2=185141&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Path.cpp (original)
+++ llvm/trunk/lib/Support/Path.cpp Fri Jun 28 05:55:41 2013
@@ -638,8 +638,7 @@ bool is_relative(const Twine &path) {
 namespace fs {
 
 // This is a mkostemps with a different pattern. Unfortunatelly OS X (ond *BSD)
-// don't have it. It might be worth experimenting with mkostemps on systems
-// that have it.
+// don't have it. We should try using mkostemps on systems that have it.
 error_code unique_file(const Twine &Model, int &ResultFD,
                        SmallVectorImpl<char> &ResultPath, bool MakeAbsolute,
                        unsigned Mode) {
@@ -648,7 +647,7 @@ error_code unique_file(const Twine &Mode
 }
 
 // This is a mktemp with a differet pattern. We use createUniqueEntity mostly
-// for consistency. It might be worth it experimenting with mktemp.
+// for consistency. We should try using mktemp.
 error_code unique_file(const Twine &Model, SmallVectorImpl<char> &ResultPath,
                        bool MakeAbsolute) {
   int Dummy;
@@ -656,7 +655,7 @@ error_code unique_file(const Twine &Mode
 }
 
 // This is a mkdtemp with a different pattern. We use createUniqueEntity mostly
-// for consistency. It might be worth it experimenting with mkdtemp.
+// for consistency. We should try using mkdtemp.
 error_code createUniqueDirectory(const Twine &Prefix,
                                  SmallVectorImpl<char> &ResultPath) {
   int Dummy;





More information about the llvm-commits mailing list