[llvm] r185139 - Make a switch in createBinary fully-covered. Add forgotten macho_dsym_companion case.
Alexey Samsonov
samsonov at google.com
Fri Jun 28 02:44:05 PDT 2013
Author: samsonov
Date: Fri Jun 28 04:44:05 2013
New Revision: 185139
URL: http://llvm.org/viewvc/llvm-project?rev=185139&view=rev
Log:
Make a switch in createBinary fully-covered. Add forgotten macho_dsym_companion case.
Modified:
llvm/trunk/lib/Object/Binary.cpp
Modified: llvm/trunk/lib/Object/Binary.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/Binary.cpp?rev=185139&r1=185138&r2=185139&view=diff
==============================================================================
--- llvm/trunk/lib/Object/Binary.cpp (original)
+++ llvm/trunk/lib/Object/Binary.cpp Fri Jun 28 04:44:05 2013
@@ -75,7 +75,8 @@ error_code object::createBinary(MemoryBu
case sys::fs::file_magic::macho_dynamically_linked_shared_lib:
case sys::fs::file_magic::macho_dynamic_linker:
case sys::fs::file_magic::macho_bundle:
- case sys::fs::file_magic::macho_dynamically_linked_shared_lib_stub: {
+ case sys::fs::file_magic::macho_dynamically_linked_shared_lib_stub:
+ case sys::fs::file_magic::macho_dsym_companion: {
OwningPtr<Binary> ret(
ObjectFile::createMachOObjectFile(scopedSource.take()));
if (!ret)
@@ -98,9 +99,13 @@ error_code object::createBinary(MemoryBu
Result.swap(ret);
return object_error::success;
}
- default: // Unrecognized object file format.
+ case sys::fs::file_magic::unknown:
+ case sys::fs::file_magic::bitcode: {
+ // Unrecognized object file format.
return object_error::invalid_file_type;
+ }
}
+ llvm_unreachable("Unexpected Binary File Type");
}
error_code object::createBinary(StringRef Path, OwningPtr<Binary> &Result) {
More information about the llvm-commits
mailing list